[CHIA-1161] Migrate test_nft_1_offers.py to WalletTestFramework
#19413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
Changed
Quexington
force-pushed
the
quex.migrate_nft1_offer_tests_to_wtf
branch
from
c4f0c11 to
28605d1
Compare
Quexington
changed the base branch from
main
to
quex.add_puzzle_generation_to_action_scopes
Quexington
force-pushed
the
quex.add_puzzle_generation_to_action_scopes
branch
from
f620e48 to
f098d35
Compare
github-actions
bot
added
the
merge_conflict
Base automatically changed from
quex.add_puzzle_generation_to_action_scopes
to
main
April 3, 2025 20:34
Quexington
force-pushed
the
quex.migrate_nft1_offer_tests_to_wtf
branch
from
28605d1 to
b0744a5
Compare
github-actions
bot
removed
the
merge_conflict
AmineKhaldi
approved these changes
Apr 8, 2025
emlowe
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR migrating to the paradigmatic test framework. Again, no changes to wallets were needed. At this point, most functionality is pretty well pinned down.
One thing I did notice, however, is that when a taker is buying an NFT that triggers royalties to themselves the wallet is not smart enough to show the royalties in their unconfirmed balance. This is so much of an edge case, I didn't bother trying to fix it, I'm not sure it's worth any dedicated logic in the offer code. That being said, if our wallet gets smart enough one day, these tests might start failing because right now they pin to the behavior that I just described. In such a case, they should be edited.