Skip to content

Conversation

countingpine
Copy link
Contributor

Fix pfSense Firewall Packet Rates formatting to display e.g. 44.91 pkts instead of %.2f pkts.

Old output example:
Values averaged over 3 min, Packets that matched a rule: %.2f pkts, Packets with bad offset: %.2f pkts, Fragmented packets: %.2f pkts, Short packets: %.2f pkts, Normalized packets: %.2f pkts, Packets dropped due to memory limitations: %.2f pkts

New output example:
Values averaged over 3 min, Packets that matched a rule: 42.06 pkts, Packets with bad offset: 0.00 pkts, Fragmented packets: 0.00 pkts, Short packets: 0.00 pkts, Normalized packets: 0.00 pkts, Packets dropped due to memory limitations: 0.00 pkts

I think these SNMP fields will be enough to test the check.

.1.3.6.1.2.1.1.1.0 = "Netgate pfSense Plus myfirewall.test.local 25.07.1-RELEASE FreeBSD 15.0-CURRENT amd64"
.1.3.6.1.4.1.12325.1.200.1.2.1.0 = 42616538
.1.3.6.1.4.1.12325.1.200.1.2.2.0 = 0
.1.3.6.1.4.1.12325.1.200.1.2.3.0 = 1
.1.3.6.1.4.1.12325.1.200.1.2.4.0 = 34
.1.3.6.1.4.1.12325.1.200.1.2.5.0 = 65
.1.3.6.1.4.1.12325.1.200.1.2.6.0 = 0

Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.

General information

Please give a brief summary of the affected device, software or appliance.
Keep in mind that we are experts in monitoring, but we cannot be experts on all supported devices.
A little context will help us assess your proposed change.

Bug reports

Please include:

  • Your operating system name and version
  • Any details about your local setup that might be helpful in troubleshooting
  • Detailed steps to reproduce the bug
  • An agent output or SNMP walk
  • The ID of a submitted crash report for reference (if applicable)

Proposed changes

Sometimes it is hard for us to assess the quality of a fix.
While it may work for you, it is our job to ensure that it works for everybody.
These are some ways to help us:

  • What is the expected behavior?
  • What is the observed behavior?
  • If it's not obvious from the above: In what way does your patch change the current behavior?
  • Consider writing a unit test that would have failed without your fix.
  • Is this a new problem? What made you submit this PR (new firmware, new device, changed device behavior)?

Fix formatting to display `44.91 pkts` instead of `%.2f pkts`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant