feat: poc pdp retrieval #8
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyropy
reviewed
May 22, 2025
lib/retrieval.js
Outdated
| @@ -0,0 +1,48 @@ | |||
| import fetch from 'node-fetch' | |||
There was a problem hiding this comment.
There's no need for using node-fetch as fetch is part of the standard library for node versions 18+ (we're using 22).
| @@ -0,0 +1,48 @@ | |||
| import fetch from 'node-fetch' | |||
| import pRetry from 'p-retry' | |||
There was a problem hiding this comment.
It's aweesome that you've added p-retry 👍🏻
test/retrieval_tests.js
Outdated
| const testFilePath = path.join(__dirname, 'testData.pdf') | ||
| const testData = await fs.readFile(testFilePath) | ||
|
|
||
| const expectedHash = createHash('sha256').update(testData).digest('hex') |
There was a problem hiding this comment.
We can save expectedHash as a constant rather then computing it for every time we run this test. This could also enable us to remove the testData.pdf file from the repository.
added 2 commits
May 22, 2025 14:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the initial implementation of the PDP Checker tool for downloading files based on Content Identifiers (CIDs).
Changes
Core Functionality:
retrieveFilefor fetching files with retry logic.Testing:
Closes #3