This repository was archived by the owner on Jun 30, 2025. It is now read-only.
ci: auto-approve only minor prettier-config updates #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up for eef0e60 (#726) which enabled auto-approvals for _all_ new versions of `@checkernetwork/prettier-config`. Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
requested review from
juliangruber,
pyropy and
NikolasHaimerl
as code owners
juliangruber
approved these changes
Apr 25, 2025
|
@bajtos I realized another reason for my arguing: While some packages behave semver-badly and intentionally release breaking changes in minor updates, those should be the exception and not the norm. The norm should be that anything that is a patch should always be merged, anything that is a minor should be merged + the devs notified, in case they want to use the new feature, anything that is a major needs careful review. |
pyropy
approved these changes
Apr 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for eef0e60 (#726), which enabled auto-approvals for all new versions of
@checkernetwork/prettier-config, and the discussion in CheckerNetwork/spark-checker#133 (comment) where we decided to auto-approve only minor updates.