-
Notifications
You must be signed in to change notification settings - Fork 14
Integrate Station Core #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current version is good enough. 👏🏻
A few places can be improved (see the unresolved threads and the top-level comments), but none is critical.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@bajtos I know what's causing this :D if (isDev) {
// Do not preserve old Activity entries in development mode
(async () => {
await fs.unlink(await getActivityFilePath())
// eslint-disable-next-line @typescript-eslint/no-empty-function
})().catch(() => {})
} We have to overwrite the file with empty content, not remove it |
This reverts commit 405ada9.
This reverts commit 0b0403c.
* debug: only publish, no tests * debug: less triggers * debug: enable asar * Revert "Integrate Station Core (#621)" This reverts commit 405ada9. * Revert "Revert "Integrate Station Core (#621)"" This reverts commit 0b0403c. * do not build snap * pkg * change how `core` is required and launched * fix lint * must use `electron-builder.yml` * add back ci * clean up
Depends on CheckerNetwork/node#100