Skip to content

Integrate Station Core #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 82 commits into from
May 5, 2023
Merged

Integrate Station Core #621

merged 82 commits into from
May 5, 2023

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Apr 5, 2023

@juliangruber juliangruber requested a review from bajtos April 5, 2023 13:09
@juliangruber juliangruber marked this pull request as ready for review April 5, 2023 13:09
@juliangruber

This comment was marked as outdated.

@juliangruber juliangruber requested a review from bajtos May 4, 2023 11:04
@bajtos

This comment was marked as outdated.

@bajtos

This comment was marked as outdated.

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current version is good enough. 👏🏻

A few places can be improved (see the unresolved threads and the top-level comments), but none is critical.

@juliangruber

This comment was marked as outdated.

@juliangruber

This comment was marked as outdated.

@juliangruber
Copy link
Member Author

Error: ENOENT: no such file or directory, access '/Users/bajtos/Library/Application Support/app.filstation.desktop/logs/activity.log'

@bajtos I know what's causing this :D

if (isDev) {
  // Do not preserve old Activity entries in development mode
  (async () => {
    await fs.unlink(await getActivityFilePath())
    // eslint-disable-next-line @typescript-eslint/no-empty-function
  })().catch(() => {})
}

We have to overwrite the file with empty content, not remove it

@juliangruber juliangruber merged commit 405ada9 into main May 5, 2023
@juliangruber juliangruber deleted the add/core branch May 5, 2023 10:09
juliangruber added a commit that referenced this pull request May 8, 2023
juliangruber added a commit that referenced this pull request May 8, 2023
juliangruber added a commit that referenced this pull request May 10, 2023
* debug: only publish, no tests

* debug: less triggers

* debug: enable asar

* Revert "Integrate Station Core (#621)"

This reverts commit 405ada9.

* Revert "Revert "Integrate Station Core (#621)""

This reverts commit 0b0403c.

* do not build snap

* pkg

* change how `core` is required and launched

* fix lint

* must use `electron-builder.yml`

* add back ci

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants