Skip to content

None #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

None #2563

wants to merge 6 commits into from

Conversation

jasperpolaxinter
Copy link

@jasperpolaxinter jasperpolaxinter commented Oct 1, 2025 •
edited
Loading

No description provided.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. frontend Pertains to the frontend. labels Oct 1, 2025
asvishnyakov
asvishnyakov requested changes Oct 1, 2025
View reviewed changes
Copy link
Member

@asvishnyakov asvishnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice idea, however we can't accept this PR as is, as it introduces breaking change

@asvishnyakov
Copy link
Member

@jasperpolaxinter Tests are failing rightfully. We need to support both URLs and icon names; otherwise, this is a breaking change and cannot be merged.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 15, 2025
@jasperpolaxinter jasperpolaxinter changed the title Using lucide icons for starters None Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvishnyakov asvishnyakov asvishnyakov requested changes

@hayescode hayescode Awaiting requested review from hayescode hayescode is a code owner

@sandangel sandangel Awaiting requested review from sandangel sandangel is a code owner

Assignees

No one assigned

Labels

frontend Pertains to the frontend. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasperpolaxinter @asvishnyakov @jsprpl