feat: implement focil EIP-7805 #7342
Draft
+2,043
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
added
the
status-do-not-merge
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
g11tech
reviewed
Jan 12, 2025
This reverts commit 7192180.
This reverts commit dffb1ac.
nflaig
reviewed
Apr 19, 2025
Comment on lines
260
to
263
| const secToNextSlot = this.config.SECONDS_PER_SLOT - this.chain.clock.secFromSlot(clockSlot); | ||
| const secToCutOff = this.config.PROPOSER_INCLUSION_LIST_CUT_OFF - this.chain.clock.secFromSlot(clockSlot); | ||
| const sleepTime = Math.min(secToNextSlot, secToCutOff) * 1000; | ||
| await sleep(sleepTime, this.signal); |
There was a problem hiding this comment.
why can't we just do what I did previously? We either wait until we reach the cutoff or otherwise we just don't sleep at all if for some reason we are past the cut off already (which shouldn't happen)
Suggested change
| const secToNextSlot = this.config.SECONDS_PER_SLOT - this.chain.clock.secFromSlot(clockSlot); | |
| const secToCutOff = this.config.PROPOSER_INCLUSION_LIST_CUT_OFF - this.chain.clock.secFromSlot(clockSlot); | |
| const sleepTime = Math.min(secToNextSlot, secToCutOff) * 1000; | |
| await sleep(sleepTime, this.signal); | |
| await sleep( | |
| Math.max(0, (this.config.PROPOSER_INCLUSION_LIST_CUT_OFF - this.chain.clock.secFromSlot(clockSlot)) * 1000), | |
| this.signal | |
| ); |
There was a problem hiding this comment.
why can't we just do what I did previously? We either wait until we reach the cutoff or otherwise we just don't sleep at all if for some reason we are past the cut off already (which shouldn't happen)
Because the kurtosis config we use when interopping/testing use mainnet preset with seconds_per_slot = 6.
So prepareNextSlot usually happens at 4s, and this.config.PROPOSER_INCLUSION_LIST_CUT_OFF - this.chain.clock.secFromSlot(clockSlot) usually yield 11 - 2 = 9 seconds of wait time. This would delay this EL call to 2 slots after.
When we are done interopping, we can remove secToNextSlot and do max(0, secToCutOff) as you suggest
There was a problem hiding this comment.
we should probably change this already on the spec, PROPOSER_INCLUSION_LIST_CUT_OFF and other timing parameters should not be part of config and always derived from SECONDS_PER_SLOT similar to proposer boost reorg cutoff
**Motivation**
FOCIL image failed in Kurtosis after switching to eip-7805 fork (slot
32):
```
[cl-1-lodestar-geth] Error: getBlobParameters is not available pre-fulu epoch=1
```
The error was triggered by `getBlobParameters()` and
`getMaxBlobsPerBlock()` functions.
**Description**
Added `ForkName.eip7805` into `getMaxBlobsPerBlock()`. Now switching the
forks works well in kurtosis.
**Steps to test or reproduce**
Kurtosis config file:
```
participants:
- el_type: geth
el_image: jihoonsg/geth-focil:4a583f4
cl_type: lodestar
cl_image: sibkatya/lodestar:focil-fork-fix
count: 2
network_params:
genesis_delay: 20
electra_fork_epoch: 0
eip7805_fork_epoch: 1
seconds_per_slot: 6
num_validator_keys_per_node: 256
snooper_enabled: true
additional_services:
- dora
- tx_fuzz
- spamoor
- prometheus_grafana
port_publisher:
additional_services:
enabled: true
public_port_start: 65500
spamoor_params:
spammers:
- scenario: eoatx
config:
throughput: 100
- scenario: uniswap-swaps
config:
throughput: 100
- scenario: blob-combined
config:
throughput: 5
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge - PR for reference only
Relevant issue #7340