Skip to content

feat(internal/client): BlockImport implementation for Client #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 172 commits into
base: development
Choose a base branch
from
Open

feat(internal/client): BlockImport implementation for Client #4647

wants to merge 172 commits into from

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Apr 7, 2025 •
edited
Loading

Changes

Implements BlockImport interface methods CheckBlock and BlockImport in internal/client Client structure.
Also adds all dependencies and helper functions

Summary

  • Implements CheckBlock method
  • Implements ImportBlock method
    • Implement prepareBlockStorageChanges
    • Implement applyBlock method
  • Modify generics to add Executor and ConstructRuntimeApi
  • Introduce ApiExt, ConstructRuntimeApi and ProvideRuntimeApi interfaces
  • Update and add new tests

Tests

make test

IMO it will be better to finish the rest of the tasks and code an integration test for the ImportBlock instead of unit testing it

Issues

Closes: #4458

dimartiro added 30 commits March 10, 2025 18:20
@dimartiro
Implement changeset, overlayedMap and extrinsics
a381b87
@dimartiro
Add licenses
c8af77a
@dimartiro
Implement OverlayedChanges struct
1499e3d
@dimartiro
Add stats
14ad93c
@dimartiro
Add more implementations and tests
f2ee10c
@dimartiro
Some TDD
5a33442
@dimartiro
changeSet set method
bfe6182
@dimartiro
changeSet set method working
eedd44d
@dimartiro
Improvements and more tests
7512632
@dimartiro
Implements commit an rollback
e3dc009
@dimartiro
Disable overlayed changes for now
b409679
@dimartiro
More tests
d202851
@dimartiro
Add append tests
dbfa0f0
@dimartiro
More test cases
3150b40
@dimartiro
Fix append
6ff04cf
@dimartiro
Implements ChangesAfter
1190d01
@dimartiro
Add more tests and fixes
5ccda95
@dimartiro
Implement changeset, overlayedMap and extrinsics
1f830a1
@dimartiro
Add licenses
15b4fde
@dimartiro
Implement OverlayedChanges struct
448a83c
@dimartiro
Add stats
b0d8815
@dimartiro
Add more implementations and tests
ab28131
@dimartiro
Some TDD
4e36de1
@dimartiro
changeSet set method
1334368
@dimartiro
changeSet set method working
3230322
@dimartiro
Improvements and more tests
309d689
@dimartiro
Implements commit an rollback
13ddf7b
@dimartiro
Disable overlayed changes for now
fba1a6f
@dimartiro
More tests
cb1ce8d
@dimartiro
Add append tests
f2ff6a9
@dimartiro dimartiro linked an issue Apr 7, 2025 that may be closed by this pull request
Implement BlockImport interface for Client type #4458
Open
dimartiro added 14 commits April 7, 2025 15:18
@dimartiro
Add missing license
bd31937
@dimartiro
Merge branch 'development' of github.com:ChainSafe/gossamer into dieg…
a44aa10 
…o/overlayed-changes
@dimartiro
Merge branch 'diego/overlayed-changes' of github.com:ChainSafe/gossam…
abf06f4 
…er into diego/block-import
@dimartiro
Merge branch 'development' of github.com:ChainSafe/gossamer into dieg…
7dcfcdf 
…o/overlayed-changes
@dimartiro
Use OffchainOverlayedChanges from offchain pkg
f8232c2
@dimartiro
Merge branch 'diego/overlayed-changes' of github.com:ChainSafe/gossam…
c4a5a44 
…er into diego/block-import
@dimartiro
Merge branch 'development' of github.com:ChainSafe/gossamer into dieg…
e1c4b32 
…o/block-import
@dimartiro
Merge branch 'diego/block-import' of github.com:ChainSafe/gossamer in…
8642ace 
…to diego/block-import-impl
@dimartiro
Complete block gap logic
803c9c6
@dimartiro
Remove TODO
c0e0c30
@dimartiro
Change comment
c2539ab
@dimartiro
Complete ResolveStateVersionFromWasm
9c8ccb4
@dimartiro
Improve errors
6aa7954
@dimartiro
ResolveStateVersionFromWasm tests
f9f5ca2
@dimartiro dimartiro force-pushed the diego/block-import-impl branch from adbf0d4 to f9f5ca2 Compare April 10, 2025 13:44
Base automatically changed from diego/block-import to development April 10, 2025 13:48
@dimartiro dimartiro marked this pull request as ready for review April 15, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@dimartiro dimartiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement BlockImport interface for Client type
1 participant
@dimartiro