Skip to content

feat(dot/rpc): Add offchain_localStorageClear RPC method #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: development
Choose a base branch
from
Draft

feat(dot/rpc): Add offchain_localStorageClear RPC method #4594

wants to merge 5 commits into from

Conversation

khssnv
Copy link

@khssnv khssnv commented Mar 9, 2025

Changes

Implements new offchain_localStorageClear RPC method introduced to the Polkadot SDK in paritytech/polkadot-sdk#7266. Motivation paritytech/polkadot-sdk#7265.

Tests

go test ./... -timeout=30m -run "^(Test_OffchainModule_LocalStorageClear|TestOffchainModule_LocalStorageClear|TestOffchainRPC)$"

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

dimartiro
dimartiro reviewed Mar 10, 2025
View reviewed changes
tests/rpc/rpc_04-offchain_test.go

fetchWithTimeout(ctx, t, "offchain_localStorageClear", "", &response)

// TODO assert response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need help to finish this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other t.Run instances in this test function are also marked as TODO, so I decided to add this one in the same way. Would you like to keep it as it is, implement this specific t.Run, or implement all three?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would be great to have at least this one implemented

@dimartiro
Copy link
Contributor

@khssnv thanks for the contribution! I looks more like a draft since there are still some TODOs to finish. If that's the case, could you please convert it to a draft while you are working on it?

@khssnv khssnv marked this pull request as draft March 10, 2025 13:57
@khssnv
Copy link
Author

khssnv commented Mar 10, 2025

@khssnv thanks for the contribution! I looks more like a draft since there are still some TODOs to finish. If that's the case, could you please convert it to a draft while you are working on it?

Thanks for the review! Converted to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimartiro dimartiro dimartiro left review comments

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@P1sar P1sar Awaiting requested review from P1sar P1sar is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khssnv @CLAassistant @dimartiro