Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splat shader Fix: Unable to obtain the position on the model using pickPosition when loading 3dgs Gaussian data #12542

Open
wants to merge 2 commits into
base: splat-shader
Choose a base branch
from

Conversation

yuqingyang0129
Copy link

Description

Issue number and link

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

…en loading 3d Gaussian data

Fix: Unable to obtain the position on the model using pickPosition when loading 3d Gaussian data
…en loading 3d Gaussian data

Fix: Unable to obtain the position on the model using pickPosition when loading 3d Gaussian data
Copy link

Thank you for the pull request, @h5developers! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

@ggetz
Copy link
Contributor

ggetz commented Mar 31, 2025

Thanks for the suggestion @h5developers.

@keyboardspecialist Would you mind taking a pass on this PR and decide if you would like to incorporate it into your branch?

@keyboardspecialist
Copy link

Yes, this is a change we already discussed making. This is necessary for not only picking, but for occlusion with other objects in the scene.

Copy link

@keyboardspecialist keyboardspecialist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. These flags are needed going forward.

@ggetz
Copy link
Contributor

ggetz commented Apr 1, 2025

@h5developers I don't think we have a CLA on file for you. We need one to merge this PR. Could you please send in a Contributor License Agreement (CLA)?

@ggetz ggetz mentioned this pull request Apr 11, 2025
6 tasks
@ggetz
Copy link
Contributor

ggetz commented Apr 11, 2025

Hi @yuqingyang0129, I dropped a comment in #12545. Could you please make the CONTRIBUTORS.md update in this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants