Skip to content

Update JSDoc #10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update JSDoc #10969

wants to merge 1 commit into from

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Dec 20, 2022

  • Updates the outdated jsdoc package
  • Install taffydb as a separate dependency, as it is no longer installed alongside jsdoc.
  • Removes unused imports from custom publish.js
  • Tweak config to align with recommended default

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor Author

ggetz commented Dec 20, 2022

tsd-jsdoc has a peer dependency of ^3.6.3, so we'll need to skip this update until tsd-jsdoc is updated or we update our TS tooling instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants