Skip to content

[ENG-8233] Do not show link addons with no targetUrl #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feature/verified-resource-linking
Choose a base branch
from
Open

[ENG-8233] Do not show link addons with no targetUrl #2585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a98f78
do not show link addons with no targetUrl
adlius Jun 18, 2025
5687b64
Merge branch 'feature/verified-resource-linking' into fix-empty-link
adlius Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/guid-node/links/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,8 @@ export default class GuidNodeLinksController extends Controller {
get currentUserCanEdit() {
return this.model.node.currentUserPermissions.includes(Permission.Write);
}

get shouldShowEmptyPage() {
return this.model.configuredLinkAddons.every((item: { targetUrl: string | null }) => item.targetUrl === null);
}
}
34 changes: 18 additions & 16 deletions app/guid-node/links/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
<div local-class='links-page-wrapper'>
<h2>{{t 'links.linked-services'}}</h2>
{{#if this.model.configuredLinkAddons}}
{{#if this.shouldShowEmptyPage}}
<p>{{t 'links.empty-screen-message'}}</p>
{{#if this.currentUserCanEdit}}
<p> {{t 'links.point-to-addons-message'}} <a href='/{{this.model.node.id}}/addons?activeFilterType=verified-link'>{{t 'addons.heading'}}</a></p>
{{/if}}
{{else}}
<table local-class='table'>
<thead>
<tr local-class='table-row'>
Expand All @@ -25,23 +30,20 @@
</thead>
<tbody>
{{#each this.model.configuredLinkAddons as |configuredLinkAddon|}}
<tr local-class='table-row'>
<td local-class='table-cell'>
<img alt={{t 'links.logo'}} local-class='logo'
src={{configuredLinkAddon.externalLinkService.iconUrl}}>
<span>{{configuredLinkAddon.externalLinkService.displayName}}</span>
</td>
<td local-class='table-cell'>{{configuredLinkAddon.displayName}}</td>
<td local-class='table-cell'>{{configuredLinkAddon.resourceType}}</td>
<td local-class='table-cell'><a target='_blank' rel='noopener noreferrer' href={{configuredLinkAddon.targetUrl}}>{{t 'links.link'}}</a></td>
</tr>
{{#if configuredLinkAddon.targetUrl}}
<tr local-class='table-row'>
<td local-class='table-cell'>
<img alt={{t 'links.logo'}} local-class='logo'
src={{configuredLinkAddon.externalLinkService.iconUrl}}>
<span>{{configuredLinkAddon.externalLinkService.displayName}}</span>
</td>
<td local-class='table-cell'>{{configuredLinkAddon.displayName}}</td>
<td local-class='table-cell'>{{configuredLinkAddon.resourceType}}</td>
<td local-class='table-cell'><a href={{configuredLinkAddon.targetUrl}}>{{t 'links.link'}}</a></td>
</tr>
{{/if}}
{{/each}}
</tbody>
</table>
{{else}}
<p>{{t 'links.empty-screen-message'}}</p>
{{#if this.currentUserCanEdit}}
<p> {{t 'links.point-to-addons-message'}} <a href='/{{this.model.node.id}}/addons?activeFilterType=verified-link'>{{t 'addons.heading'}}</a></p>
{{/if}}
{{/if}}
</div>
Loading