Serialize spells to JSON using Locale-aware context #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the spell codec to serialize spells to JSON using the application
Context(which isLocale-aware). It's thisContextobject that's used for the JSON spell parsing, so we should use the same one both ways. Currently the USLocaleis used, which causes homebrew spells to be not parse in the Portuguese version. This hasn't come up until now because the only time that we serialize spells to JSON is when saving homebrew spells, and that's a new feature that hasn't been released yet. Additionally, this PR also make a couple of other (unrelated) minor changes.