feat: organization default sharing for new caps - #2140
Open
richiemcilroy wants to merge 11 commits into
Open
Conversation
richiemcilroy
marked this pull request as ready for review
August 20, 2026 09:54
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an org-level default for how new caps are shared, configurable in Settings > Organization > Preferences under a new Default sharing section: visibility (anyone with the link / private) and an optional default password applied to new caps automatically.
organizations.settings.defaultVideoPublic+ neworganizations.defaultVideoPasswordcolumn (PBKDF2 hash, same format as per-video passwords; never plaintext, never sent to clients - dashboard exposes onlyhasDefaultVideoPassword).resolveNewVideoDefaults) now feeds all 10 creation paths (desktop, web uploads, instant, Loom imports, mobile, developer API); duplicates keep inheriting the source cap's visibility. Falls back toCAP_VIDEOS_DEFAULT_PUBLICwhen unset.defaultVideoPublicfor parity (merge semantics, cannot wipe other settings); no password surface added to MCP.Migration note: apply
ALTER TABLE organizations ADD defaultVideoPassword text;(migration 0040) to PlanetScale before deploying - drizzle enumerates columns, so org queries would fail without it.Validated: new resolver unit tests plus affected test files 20/20; full web unit suite and typecheck show only pre-existing failures; biome clean.
Also redesigns the organization settings screens in the same PR (Linear-style settings system):
SettingsRows.tsx): section heading above a white rounded card of hairline-divided rows, label + description left, one compact control right, pill select triggers with check-marked menus.Greptile Summary
Adds organization-level visibility and password defaults that are copied onto newly created caps across web, desktop, mobile, Loom-import, and agent API paths.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains; the previous visibility mismatch is fixed, and the generated migration artifacts follow the repository’s required committed-generation workflow.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(web): show instance fallback for uns..." | Re-trigger Greptile
Context used (4)
packages/database)