Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-empty Reactor and Connector Objects #1788

Closed
wants to merge 32 commits into from

[samples] Update cxx samples

c17b309
Select commit
Loading
Failed to load commit list.
Closed

Non-empty Reactor and Connector Objects #1788

[samples] Update cxx samples
c17b309
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 15, 2024 in 0s

73.33% (+0.09%) compared to dd26e18

View this Pull Request on Codecov

73.33% (+0.09%) compared to dd26e18

Details

Codecov Report

Attention: Patch coverage is 74.58034% with 106 lines in your changes missing coverage. Please review.

Project coverage is 73.33%. Comparing base (dd26e18) to head (c17b309).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/clib/ctreactor.cpp 45.45% 30 Missing ⚠️
src/zeroD/ReactorSurface.cpp 30.00% 9 Missing and 5 partials ⚠️
src/zeroD/ConnectorFactory.cpp 72.22% 10 Missing ⚠️
src/zeroD/ReactorFactory.cpp 70.96% 9 Missing ⚠️
include/cantera/base/FactoryBase.h 56.25% 7 Missing ⚠️
src/zeroD/ReactorNode.cpp 69.56% 6 Missing and 1 partial ⚠️
interfaces/cython/cantera/reactor.pyx 90.16% 6 Missing ⚠️
src/zeroD/ReactorNet.cpp 76.19% 3 Missing and 2 partials ⚠️
include/cantera/zeroD/ReactorNode.h 66.66% 4 Missing ⚠️
include/cantera/zeroD/ReactorBase.h 0.00% 3 Missing ⚠️
... and 8 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
+ Coverage   73.23%   73.33%   +0.09%     
==========================================
  Files         381      389       +8     
  Lines       54376    54459      +83     
  Branches     9253     9270      +17     
==========================================
+ Hits        39824    39935     +111     
+ Misses      11579    11551      -28     
  Partials     2973     2973

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov