Skip to content

[frontend] POC rtk-redux-query #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[frontend] POC rtk-redux-query #1522

wants to merge 1 commit into from

Conversation

iamdey
Copy link
Member

@iamdey iamdey commented May 8, 2021

  • implement for tags
  • manage progressive migration with legacy store and components

req #1521

@iamdey
[frontend] POC rtk-redux-query
f20b893 
- implement for tags
- manage progressive migration with legacy store and components
@iamdey iamdey requested a review from MonsieurLanza May 8, 2021 09:15
@iamdey
Copy link
Member Author

iamdey commented May 8, 2021 •
edited
Loading

pro

  • looks nice and very well conceived
  • pretty stable
  • abstract cache management and invalidation

cons

  • still not sec / stable released
  • low level actions not easy to manipulate and not well documented
  • is it easy to use for newbies?
  • a lot of abstraction

other thoughts?

@iamdey
Copy link
Member Author

iamdey commented May 8, 2021

release beta 3 is the last release before integrated to rtk and it is ok to start using it in prod: https://github.com/rtk-incubator/rtk-query/releases

@iamdey
Copy link
Member Author

iamdey commented May 8, 2021

iamdey
iamdey commented May 10, 2021
View reviewed changes
src/frontend/web_application/src/modules/tags/store/index.ts
// type TagAPIDeleteResult = never;
type TagAPIDeleteResult = {
foo: string;
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@iamdey iamdey closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonsieurLanza MonsieurLanza Awaiting requested review from MonsieurLanza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamdey