Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RavenDB 4 support #29

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

RavenDB 4 support #29

wants to merge 66 commits into from

Conversation

adsamcik
Copy link

@adsamcik adsamcik commented Mar 31, 2018

Still needs some work, but currently it seems to work well. Currently some of the session loads should be replaced with patches which I didn't have time for yet. But current state is better than nothing.

@AustinWinstanley
Copy link
Contributor

Wow. This is amazing work. Thanks @adsamcik! I haven't had a chance to review it and test it yet, but I will soon and I will merge it in if everything looks good,

@adsamcik
Copy link
Author

I have been learning RavenDB on it so it might not be as good and optimized as someone else could make it, but I have been using it for awhile and it seems mostly ok. To get it working I removed patches and indexes because I had no idea how they worked. Also in repository I had hard time modifying it so I just created the most basic way and it worked for my case, like I said, almost no experience with this.

@AustinWinstanley
Copy link
Contributor

I'll take a look soon, but indexes are a core part of RavenDB. Without Indexes, it won't be able to be merged. Like I said, I'll check it out though.

@adsamcik
Copy link
Author

True, but since 4.0 at least I think it is since 4.0, RavenDB can create them automatically based on queries. So it wasn't a priority for me to add them manually.

@JudahGabriel
Copy link

What's the status of this PR? I'd like to use Hangfire.Raven with the latest Raven release (4.1 at the time of this writing).

@Echarnus
Copy link

Echarnus commented Jun 7, 2019

Is this still in development?

@adsamcik
Copy link
Author

adsamcik commented Jun 7, 2019

Is this still in development?

No, but you can always fork it/download it and build it yourself (since it never got merged). I used it for quite some time without major issues, but I don't know if it works well with RavenDB 4.2 since I decided to abandon server side for the project I made this for.

From what I remember there are couple of things that need improving but overall it should work fine. Index creation comes to mind (IIRC it relies on RavenDB to create indexes as needed), but surely there are more things.

//Edit
I noticed that you already made PR. I hope my previous work helps you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants