Conversation
Signed-off-by: Peter Jung <admin@ptr1337.dev>
Signed-off-by: Peter Jung <admin@ptr1337.dev>
Signed-off-by: Peter Jung <admin@ptr1337.dev>
Member
Author
|
@awlx Would you mind to review? Blocky added in recent release support for DoQ. |
Contributor
|
Oh nice! Will fully review on Thursday as I am currently on holiday. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds DNS-over-QUIC (DoQ) support alongside existing DoH support by routing encrypted DNS through the local blocky proxy, and updates both the GUI DNS page and CLI to configure DoQ-capable upstreams.
Changes:
- Add DoQ upstream presets and a unified
BlockyModeabstraction for DoH/DoQ. - Update the DNS GUI to expose a DoQ toggle and a custom DoQ endpoint field, with mutual exclusion between DoT/DoH/DoQ.
- Update CLI handling and actions to use a unified
change_dns_server_blocky()path for encrypted DNS via blocky.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pages/dns.rs | Adds DoQ UI controls, custom DoQ endpoint handling, and blocky-mode-aware selection/application logic. |
| src/dns.rs | Introduces DoQ preset endpoints plus BlockyMode and helpers for reading/writing blocky upstreams. |
| src/cli_handler.rs | Extends DNS CLI flows to support DoQ and reuses shared blocky application helpers. |
| src/actions.rs | Replaces DoH-specific blocky application with a mode-aware blocky configuration/apply function. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+179
to
+180
| let doq_check = gtk::CheckButton::with_label(&fl!("enable-doq")); | ||
| doq_check.set_tooltip_text(Some(&fl!("doq-tooltip"))); |
Comment on lines
+202
to
+203
| dns::BlockyMode::Doh => fl!("doh-blocky-install-failed"), | ||
| dns::BlockyMode::Doq => fl!("doq-blocky-install-failed"), |
| if !valid { | ||
| let msg = match mode { | ||
| dns::BlockyMode::Doh => fl!("custom-dns-doh-url-required"), | ||
| dns::BlockyMode::Doq => fl!("custom-dns-doq-endpoint-required"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation will be added after the current open Translation PRs are merged.
Signed-off-by: Peter Jung admin@ptr1337.dev