Skip to content

Add log to channel on shutdown and startup #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

MattyTheHacker
Copy link
Member

No description provided.

Copy link
Member

@CarrotManMatt CarrotManMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would send a duplicated message into the log channel. Whenever a log message is sent via logger.info(), logger.error() etc, it is sent to every destination (console & log channel), but may be filtered out. The reason why the messages are not being sent to the log channel is because the default level is set to WARNING so the info messages aren't shown. If you would like to see the INFO level messages like this ready message, the log level of the Discord logger needs to be set to allow INFO messages.

The Discord channel log level will be configurable as a config variable rather than being hard-coded after merging of #221

@MattyTheHacker
Copy link
Member Author

I think this is a case where we (I) would want those messages sent regardless of log level - hence the way I've written it, but i didn't realise it would duplicate

@CarrotManMatt
Copy link
Member

Unfortunately there is no possible way to send the message all of the time to the log channel and not have it duplicated (without not sending it to the console)

@CarrotManMatt CarrotManMatt added the refactor Improvements to the codebase that do not directly affect users label Jul 29, 2024
@MattyTheHacker MattyTheHacker deleted the add-shutdown-logging branch July 30, 2024 11:15
@CarrotManMatt CarrotManMatt added the wontfix This will not be worked on label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to the codebase that do not directly affect users wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants