Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digestion #98

Merged
merged 13 commits into from
Jun 27, 2020
Merged

Digestion #98

merged 13 commits into from
Jun 27, 2020

Conversation

ZimmerD
Copy link
Member

@ZimmerD ZimmerD commented Jun 26, 2020

Please reference the issue(s) this PR is related to

Closes #97

Please list the changes introduced in this PR

  • Completed Digestion.BioSeq module
  • Added and completed Digestion.BioList module
  • Added Unit tests for both modules and the Digestion.BioArray module.
  • fixed typos.

Description
This PR provides implementations for the seq and List data structures following the Digestion.BioArray module.

[Required] please make sure you checked that

  • The project builds without problems on your machine

[Optional]

  • Added unit tests regarding the added features

@ZimmerD ZimmerD requested a review from kMutagene June 26, 2020 12:19
@kMutagene
Copy link
Member

Awesome, thanks!

MissCleavages: int
CleavageStart:int
CleavageEnd: int
///Sequence of peptide
PepSequence: AminoAcid list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genuine question: is AminoAcidList an artifact before BioList existed? I guess this can be changed to BioList without breaking previous versions. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to #95

@kMutagene kMutagene merged commit e249af0 into CSBiology:developer Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants