refactor!: Remove node parameter from Circuit #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to
hugr 0.15
added aNode
associated type toHugrView
.Over here, that got implemented as a new type parameter in
Circuit
,All
impl
blocks however restrain it to the specific hugr support,Given how both types are connected, we should be using
T::Node
directly since an unrelated node type is not usable here.This PR changes the definition to
As this is a breaking change, it can wait until the next breaking release.
BREAKING CHANGE: Removed node type parameter from
Circuit