Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mtkahypar and poetry #144

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Update mtkahypar and poetry #144

wants to merge 11 commits into from

Conversation

trvto
Copy link
Collaborator

@trvto trvto commented Mar 20, 2025

Description

  • Update to mtkahypar version to 1.5
  • Use poetry 2.1.1 and require at least 2.0.0.
    • Updated the pyproject.toml to reflect this

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@trvto trvto requested a review from cqc-melf as a code owner March 20, 2025 17:26
Copy link
Collaborator

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few questions

pyproject.toml Outdated
"pydantic >=2.0",
"networkx >=3.0",
"sympy >=1.6",
"qiskit-aqt-provider >=1.8.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if this still works or should we go to 1.11?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line 51 qiskit-aqt-provider = {version = "~1.8.1", extras = ["test"]}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 51 would only allow 1.8.x, this line allows 1.11 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now updated both to allow 1.10. They introduced breaking changes annoyingly but wasn't too hard to fix. I think ">=" is better to keep up to date

@trvto trvto requested a review from cqc-melf March 21, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run partitioning tests on the CI
2 participants