feat: Add boundary edge traversal in SimpleReplacement #2231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2231 +/- ##
==========================================
+ Coverage 82.00% 82.03% +0.03%
==========================================
Files 234 234
Lines 41619 41702 +83
Branches 37532 37616 +84
==========================================
+ Hits 34128 34209 +81
Misses 5518 5518
- Partials 1973 1975 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lmondada
requested review from
acl-cqc and
aborgna-q
and removed request for
acl-cqc
aborgna-q
approved these changes
May 20, 2025
| #[derive(Debug, Clone, Copy)] | ||
| /// This is used to represent boundary edges that will be added between the host | ||
| /// and replacement graphs when applying a rewrite. | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)] |
There was a problem hiding this comment.
Add Hash too ? (same on HostPort)
Closed
This was referenced May 29, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe these methods finally expose the "right" way to think of the boundary between a replacement and its subgraph, in particular this won't be broken as we extend
SiblingSubgraphto express more types of subgraphs (see issue #2212).The idea is simple: for any replacement, there must be links between ports that are just outside the
subgraphin host, and ports that are linked to the input and output nodes of thereplacement. These links are precisely the edges that will need to be added when the replacement is applied, between the existing host HUGR and the newly added nodes of thereplacement. Specifically these edges link:hostthat are "just before the subgraph" (i.e. ports linked to an incoming port ofsubgraph) to incoming ports inreplacementthat are linked to the input node, andhostthat are "just after the subgraph" (i.e. ports linked to an outgoing port ofsubgraph) to outgoing ports inreplacementthat are linked to the output node.