Skip to content

fix: Fix the grammar for constant function terms #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zrho
Copy link
Contributor

@zrho zrho commented Apr 29, 2025

This PR fixes the PEST grammar for constant function terms. It erroneously expected a nested term instead of a nested region. Regression tests are included.

zrho added 2 commits April 25, 2025 13:33
This PR removes the `model_unstable` feature flag across the repository.
Closes #2104.

BREAKING CHANGE: Downstream crates need to remove the `model_unstable`
feature flag when referencing `hugr` or `hugr-core`.
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (0b091e2) to head (abf57cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2139      +/-   ##
==========================================
+ Coverage   83.09%   83.14%   +0.05%     
==========================================
  Files         219      219              
  Lines       41918    41910       -8     
  Branches    37993    37985       -8     
==========================================
+ Hits        34830    34846      +16     
+ Misses       5278     5252      -26     
- Partials     1810     1812       +2     
Flag Coverage Δ
python 85.70% <ø> (ø)
rust 82.88% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented Apr 29, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/feature_missing.ron

Failed in:
feature model_unstable in the package's Cargo.toml
feature hugr-model in the package's Cargo.toml

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/feature_missing.ron

Failed in:
feature hugr-model in the package's Cargo.toml
feature model_unstable in the package's Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants