Skip to content

feat(hugr-passes)!: Add UnNonLocalPass #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

feat(hugr-passes)!: Add UnNonLocalPass #1912

wants to merge 27 commits into from

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Feb 6, 2025

BREAKING CHANGE: TODO deets, changed NonLocalEdgesError

closes #1234

@doug-q doug-q changed the title feat!: Add UnNonLocalPass feat(hugr-passes)!: Add UnNonLocalPass Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 98.11321% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.26%. Comparing base (9985143) to head (558b5d5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hugr-passes/src/non_local.rs 98.11% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
+ Coverage   82.00%   82.26%   +0.26%     
==========================================
  Files         234      234              
  Lines       41618    42308     +690     
  Branches    37532    38221     +689     
==========================================
+ Hits        34127    34804     +677     
- Misses       5518     5527       +9     
- Partials     1973     1977       +4     
Flag Coverage Δ
python 85.22% <ø> (+<0.01%) ⬆️
rust 81.94% <98.11%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented Feb 6, 2025

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary

--- failure derive_trait_impl_removed: built-in derived trait no longer implemented ---

Description:
A public type has stopped deriving one or more traits. This can break downstream code that depends on those types implementing those traits.
      ref: https://doc.rust-lang.org/reference/attributes/derive.html#derive
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/derive_trait_impl_removed.ron

Failed in:
type NonLocalEdgesError no longer derives Clone, in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/non_local.rs:66
type NonLocalEdgesError no longer derives Eq, in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/non_local.rs:66

github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2025
…2018)

* Does not handle nonlocal edges. This is much more involved, not part
of this PR. I note #1912
* handlers for arrays follow in #2023

BREAKING CHANGE: `OpReplacement` renamed to `NodeTemplate`. Note this is
*not* a breaking change if this PR goes in the same release as #1989
(which introduced `OpReplacement`)

---------

Co-authored-by: Douglas Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a "remove-nonlocal-edges" pass
2 participants