BFD-3848: Transient SFTP connection errors are affecting BFD EFT Outbound in test #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malessi
requested review from
mjburling,
dondevun and
aschey-forpeople
as code owners
aschey-forpeople
previously approved these changes
Feb 5, 2025
…ges upon the Lambda failing 3 times
dondevun
approved these changes
Feb 6, 2025
mjburling
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3848
What Does This PR Do?
This PR updates the maximum Lambda retries to 3 instead of disabling retries outright. Initially, the fear was that this Lambda was not idempotent, but after some investigation we determined that it is actually idempotent and the Lambda as a whole can be retried. Accordingly, the CloudWatch Alarms alerting on failures for this Lambda has been updated to alert after 3 failures in a 10 minute period so that the on-call is not alerted if the Lambda is able to recover automatically.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependenciesModifies any security controlsAdds new transmission or storage of dataAny other changes that could possibly affect security?I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
terraform applyeftintest, verifying that theapplyis successful and all resources are updated