Skip to content

move some of the Validators to an ExtraValidators file #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Aug 10, 2025

Rework some of the validator locations, add documentation, and fix some lingering issues with validators.
The extra will will enable additions of some new validators and reduce compile times for those that are not needed.

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e4ee3af) to head (4b5af60).
⚠️ Report is 114 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1192     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           17        19      +2     
  Lines         4546      5193    +647     
  Branches         0      1062   +1062     
===========================================
+ Hits          4546      5193    +647     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phlptp
Copy link
Collaborator Author

phlptp commented Aug 13, 2025

Will Fix #1191

@phlptp
Copy link
Collaborator Author

phlptp commented Aug 13, 2025

@henryiii I think you are going to need to modify the codacy configuration on their website, I don't think I can fix the false positives on codacy in a configuration, so that will need to be handled by the administrator of the codacy configuration, which I think is you. I think we might want to just disable cppcheck on codacy, I am not seeing it providing much value over the other static checking we are doing.

@phlptp phlptp marked this pull request as ready for review August 20, 2025 12:26
@phlptp phlptp requested a review from henryiii August 20, 2025 12:27
@phlptp
Copy link
Collaborator Author

phlptp commented Aug 20, 2025

@henryiii This change will allow us to add some additional validators in a way that doesn't impact compile time unless they are needed. Also adds some additional documentation on custom validators that has been requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant