Skip to content

Add antigen compatible plugin description #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

matthewfranglen
Copy link
Contributor

This adds antigen support for ZSH. See https://github.com/zsh-users/antigen for more details.

This allows a user to start using this library using the command:

antigen bundle matthewfranglen/gitflow-cjs --branch=develop

Which handles downloading the repository and adding the command to your path.

I'm opening this PR as suggested by you in this comment.

This adds antigen support for ZSH. See
https://github.com/zsh-users/antigen for more details.

This allows a user to start using this library using the command:

```bash
antigen bundle matthewfranglen/gitflow-avh
```

Which handles downloading the repository and adding the command to your
path.
@matthewfranglen
Copy link
Contributor Author

I would add that this explicitly uses the master branch in the file. The example I have provided uses develop because that is the branch I have forked.

# https://github.com/zsh-users/antigen

# Install gitflow-avh:
# antigen bundle petervanderdoes/gitflow-avh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed were still referencing the original repository and not my fork. Is this due to antigen itself needing to know where to pull from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry I literally just copied the commits and pushed to this repo. You are correct that the comments should reference this repo.

@ChrisJStone
Copy link
Member

Looking over your pull request a second time with a fresh pair of eyes. I now understand that this is preventing the need to install gitflow-cjs separately. The way I read the comments initially was a little confusing to me and I had the impression gitflow-cjs needed to be installed first then run antigen bundle. I'll make the changes on my local feature branch and get them merged in.

@ChrisJStone ChrisJStone mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants