Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wastewater data to pyrenew_hew_data #317

Merged
merged 46 commits into from
Feb 19, 2025
Merged

Add wastewater data to pyrenew_hew_data #317

merged 46 commits into from
Feb 19, 2025

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Jan 31, 2025

Added prep_ww_data.py: extracting, cleaning, and preprocessing NWSS data.
Updated prep_data.py: incorporate wastewater data into the training data.
Updated pyrenew_hew_data.py: downstream processing of wastewater data.
Added a test in test_pyrenew_hew_data.py
Misc:
Renamed some variables in the wastewater model for clarity.
Standardized date handling using datetime.date.

To do: Update path for NWSS data

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 59.72222% with 58 lines in your changes missing coverage. Please review.

Project coverage is 28.83%. Comparing base (026f1eb) to head (71bde69).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pipelines/prep_ww_data.py 0.00% 37 Missing ⚠️
pyrenew_hew/pyrenew_hew_data.py 86.17% 13 Missing ⚠️
pipelines/forecast_state.py 0.00% 7 Missing ⚠️
pipelines/prep_data.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   26.86%   28.83%   +1.96%     
==========================================
  Files          24       25       +1     
  Lines        1768     1897     +129     
==========================================
+ Hits          475      547      +72     
- Misses       1293     1350      +57     
Flag Coverage Δ
hewr 35.35% <ø> (ø)
pipelines 14.06% <10.00%> (-0.77%) ⬇️
pyrenew_hew 37.62% <86.17%> (+7.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review February 6, 2025 15:49
Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good, thanks @sbidari! A few questions and suggestions.

@damonbayer damonbayer self-requested a review February 11, 2025 19:13
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbidari! I left many comments. After you respond, I would like to review the whole PR again, as it was a bit much to do at one time.

@sbidari sbidari requested a review from damonbayer February 12, 2025 23:43
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbidari! Please address a few remaining comments.

@dylanhmorris
Copy link
Contributor

Merging in the CI fix so we can check that the pipeline runs.

@sbidari sbidari merged commit 6fac159 into main Feb 19, 2025
15 checks passed
@sbidari sbidari deleted the add-wastewater-data branch February 19, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants