-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wastewater data to pyrenew_hew_data #317
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 26.86% 28.83% +1.96%
==========================================
Files 24 25 +1
Lines 1768 1897 +129
==========================================
+ Hits 475 547 +72
- Misses 1293 1350 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good, thanks @sbidari! A few questions and suggestions.
Co-authored-by: Dylan H. Morris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbidari! I left many comments. After you respond, I would like to review the whole PR again, as it was a bit much to do at one time.
Co-authored-by: Damon Bayer <[email protected]>
…-wastewater-data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbidari! Please address a few remaining comments.
Merging in the CI fix so we can check that the pipeline runs. |
Added
prep_ww_data.py
: extracting, cleaning, and preprocessing NWSS data.Updated
prep_data.py
: incorporate wastewater data into the training data.Updated
pyrenew_hew_data.py
: downstream processing of wastewater data.Added a test in
test_pyrenew_hew_data.py
Misc:
Renamed some variables in the wastewater model for clarity.
Standardized date handling using
datetime.date
.To do: Update path for NWSS data