-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rds postgres instance #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great for demo and a POC. I'll may borrow some of this for the other AWS work coming up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Am I missing where the Postgres credentials are provided to the TEFCA Viewer app though?
I'm with @DanPaseltiner on this and I'm not sure I see it. @marycrawford have you tested that the tefca viewer app is able to connect to the database? |
The TEFCA Viewer isn't currently connecting to a DB, but we will need one in the next sprint or so. Hope was to put the infrastructure in place for development starting in the next couple sprints. I think just providing the creds as environment variables for now is sufficient. Obviously for production we would want to use a proper secret manager. @marycrawford and I discussed all of this earlier today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little late to the party but LGTM!
Let me know if this item needs any additional work! Given the approvals, it has been merged. |
PULL REQUEST
Summary
What changes are being proposed?
Related Issue
Additional Information
Current PR is to create a postgres database to communicate with the tefca-viewer. This phase is for development and demo purposes. Additional tickets and work will be made to refactor this work for production (i.e. secrets manager, etc. for the db password).
AWS
rds
resourcesAWS
iam
roles and polices for the postgres db to communicate with the tefca-viewer