Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rds postgres instance #82

Merged
merged 17 commits into from
Aug 5, 2024
Merged

Conversation

marycrawford
Copy link
Collaborator

@marycrawford marycrawford commented Jul 26, 2024

PULL REQUEST

Summary

What changes are being proposed?

Related Issue

  • resolve CDCgov/phdi#2226

Additional Information

Current PR is to create a postgres database to communicate with the tefca-viewer. This phase is for development and demo purposes. Additional tickets and work will be made to refactor this work for production (i.e. secrets manager, etc. for the db password).

  • Creates a module for AWS rds resources
  • Creates AWS iam roles and polices for the postgres db to communicate with the tefca-viewer

@marycrawford marycrawford marked this pull request as draft July 26, 2024 05:58
Copy link
Collaborator

@alismx alismx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great for demo and a POC. I'll may borrow some of this for the other AWS work coming up.

.github/workflows/awsDeployment.yaml Outdated Show resolved Hide resolved
terraform/aws/implementation/modules/rds/main.tf Outdated Show resolved Hide resolved
terraform/aws/implementation/modules/rds/variables.tf Outdated Show resolved Hide resolved
@marycrawford marycrawford marked this pull request as ready for review July 31, 2024 16:10
Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Am I missing where the Postgres credentials are provided to the TEFCA Viewer app though?

terraform/aws/implementation/modules/rds/main.tf Outdated Show resolved Hide resolved
@alismx
Copy link
Collaborator

alismx commented Jul 31, 2024

Looks great. Am I missing where the Postgres credentials are provided to the TEFCA Viewer app though?

I'm with @DanPaseltiner on this and I'm not sure I see it. @marycrawford have you tested that the tefca viewer app is able to connect to the database?

@DanPaseltiner
Copy link
Collaborator

Looks great. Am I missing where the Postgres credentials are provided to the TEFCA Viewer app though?

I'm with @DanPaseltiner on this and I'm not sure I see it. @marycrawford have you tested that the tefca viewer app is able to connect to the database?

The TEFCA Viewer isn't currently connecting to a DB, but we will need one in the next sprint or so. Hope was to put the infrastructure in place for development starting in the next couple sprints. I think just providing the creds as environment variables for now is sufficient. Obviously for production we would want to use a proper secret manager. @marycrawford and I discussed all of this earlier today.

@alismx alismx requested a review from DanPaseltiner August 2, 2024 18:57
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late to the party but LGTM!

@rin-skylight rin-skylight merged commit e709f91 into main Aug 5, 2024
6 checks passed
@rin-skylight rin-skylight deleted the create-rds-postgres-instance branch August 5, 2024 18:01
@rin-skylight
Copy link
Collaborator

Let me know if this item needs any additional work! Given the approvals, it has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants