Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional context for phdi-chart versioning #78

Conversation

robertandremitchell
Copy link
Collaborator

PULL REQUEST

Summary

Adds additional context for how the code ensures we are pulling the latest version of phdi-charts.

Related Issue

Fixes #1932

Additional Information

There's an additional PR on phdi-charts to give context there, as well.

Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Like the simplicity and duplication between the two files.

Copy link
Collaborator

@m-goggins m-goggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small suggestion to clarify the first sentence but feel free to change if I didn't articulate it correctly since I haven't been as close to the helm charts in a minute.

terraform/aws/implementation/description.md Outdated Show resolved Hide resolved
@robertandremitchell robertandremitchell merged commit 8e209cc into main Jun 13, 2024
6 checks passed
@robertandremitchell robertandremitchell deleted the rob/1932-make-helm-charts-use-the-latest-version-of-each-services-image-in-valuesyaml branch June 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants