Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Karpenter for EKS autoscaling #52

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

nickclyde
Copy link
Member

@nickclyde nickclyde commented Feb 14, 2024

PULL REQUEST

Summary

Adds Karpenter for autoscaling EKS nodes. Mostly followed this example.

Related Issue

Fixes https://github.com/CDCgov/phdi/issues/1035

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for figuring this out @nickclyde. Karpenter looks pretty cool. I'm curious about one thing. How are we planning to do this Azure or has it already been done? The reason I ask is that based on my understanding of how the AKS cluster will be provisioned in CDC EXT we may run into problems making the required changes to install Karpenter as we are doing here.

@nickclyde
Copy link
Member Author

@DanPaseltiner in Azure we have this set up using KEDA:
https://github.com/CDCgov/phdi-playground/blob/main/terraform/implementation/main.tf#L423

@rin-skylight rin-skylight self-requested a review February 15, 2024 17:48
Copy link
Collaborator

@marycrawford marycrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -351,3 +351,7 @@ data "kubernetes_ingress_v1" "ingress" {
}
}
}

data "aws_ecrpublic_authorization_token" "token" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this is already set to us-east-1. I think there was a bug reported because the public ECR is defaulted to Virginia for the aws_ecrpublic_authorization_token.

@nickclyde nickclyde merged commit 8112982 into main Feb 20, 2024
4 checks passed
@nickclyde nickclyde deleted the nickclyde/aws-autoscaling branch February 20, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants