-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Karpenter for EKS autoscaling #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for figuring this out @nickclyde. Karpenter looks pretty cool. I'm curious about one thing. How are we planning to do this Azure or has it already been done? The reason I ask is that based on my understanding of how the AKS cluster will be provisioned in CDC EXT we may run into problems making the required changes to install Karpenter as we are doing here.
@DanPaseltiner in Azure we have this set up using KEDA: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -351,3 +351,7 @@ data "kubernetes_ingress_v1" "ingress" { | |||
} | |||
} | |||
} | |||
|
|||
data "aws_ecrpublic_authorization_token" "token" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad this is already set to us-east-1
. I think there was a bug reported because the public ECR is defaulted to Virginia for the aws_ecrpublic_authorization_token
.
PULL REQUEST
Summary
Adds Karpenter for autoscaling EKS nodes. Mostly followed this example.
Related Issue
Fixes https://github.com/CDCgov/phdi/issues/1035