RFC-003: skip values #218
Open
RFC-003: skip values #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 97.65% 97.62% -0.03%
==========================================
Files 32 32
Lines 1618 1601 -17
==========================================
- Hits 1580 1563 -17
Misses 38 38 ☔ View full report in Codecov by Sentry. |
m-goggins
reviewed
Feb 18, 2025
Comment on lines
+141
to
+147
| A key question to consider is whether the concept of skip value conditions accounts for all | ||
| possible scenarios. Do we need more complex rules that evaluate multiple attributes | ||
| simultaneously? For example, should an `ADDRESS` of "123 Main St" be skipped only if the | ||
| `ZIP` is also "99999"? While supporting rules of this complexity wouldn't require | ||
| significant changes to the specification, it would increase the implementation complexity. | ||
| We recommend pursuing this type of **and** logic only if there is a clear and specific need | ||
| for it. |
There was a problem hiding this comment.
Does NBS have skip values? I imagine theirs would give us insight into how complex the skip rules might be.
There was a problem hiding this comment.
Its a good thought, I brought it up with their team today. I believe the answer is no, but they'll get back to us on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A proposal to introduce system changes allowing users to define skip conditions for placeholder values to be ignored during the linkage process.
Related Issues
closes #215
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: