Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gender matching Feature [Executive Order 14168] #185

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Jan 30, 2025

Description

Removing the Gender matching field per Executive Order 14168.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the feature New feature or request label Jan 30, 2025
@ericbuckley ericbuckley self-assigned this Jan 30, 2025
@ericbuckley ericbuckley marked this pull request as ready for review January 30, 2025 19:54
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (5bff4d1) to head (0456f4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   97.56%   97.51%   -0.06%     
==========================================
  Files          31       31              
  Lines        1521     1487      -34     
==========================================
- Hits         1484     1450      -34     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley changed the title Remove Gender matching Feature [Defending Women Task Order] Remove Gender matching Feature [Executive Order 14168] Jan 30, 2025
@ericbuckley ericbuckley merged commit 9942907 into main Jan 31, 2025
15 checks passed
@ericbuckley ericbuckley deleted the feature/removing-gender branch January 31, 2025 00:09
Copy link
Collaborator

@aathwal3 aathwal3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a comment along the lines of

//removed gender field in order to comply with Executive Order 14168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants