Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix msodbcsql installation #171

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix msodbcsql installation #171

merged 1 commit into from
Jan 15, 2025

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Jan 15, 2025

Description

mysodbsql17 can no longer be found when building ubuntu, upgrading to version 18 so we can continue building.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the bug Something isn't working label Jan 15, 2025
@ericbuckley ericbuckley self-assigned this Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.26%. Comparing base (b14c46e) to head (53e9f9b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   97.21%   97.26%   +0.05%     
==========================================
  Files          30       30              
  Lines        1328     1353      +25     
==========================================
+ Hits         1291     1316      +25     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review January 15, 2025 15:39
@ericbuckley ericbuckley merged commit 68503f4 into main Jan 15, 2025
14 checks passed
@ericbuckley ericbuckley deleted the fix/docker-msodbcsql-fix-3 branch January 15, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants