Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test cleanup #165

Merged
merged 4 commits into from
Jan 3, 2025
Merged

unit test cleanup #165

merged 4 commits into from
Jan 3, 2025

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Jan 3, 2025

Description

Auto delete unit testing artifacts post completion.

Additional Notes

Also making a small fix to the local_server.sh script to run the source code in the src/ directory and not what has been installed into the virtualenv.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (ecec238) to head (362f18f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          30       30           
  Lines        1328     1328           
=======================================
  Hits         1291     1291           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley self-assigned this Jan 3, 2025
@ericbuckley ericbuckley added the qa Technical improvements to increase code quality label Jan 3, 2025
@ericbuckley ericbuckley marked this pull request as ready for review January 3, 2025 18:38
@ericbuckley ericbuckley merged commit a58652c into main Jan 3, 2025
13 checks passed
@ericbuckley ericbuckley deleted the qa/unit-test-cleanup branch January 3, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Technical improvements to increase code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants