generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(matchers): rename matchers funcs for clarity #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 95.47% 96.43% +0.95%
==========================================
Files 31 30 -1
Lines 1414 1317 -97
==========================================
- Hits 1350 1270 -80
+ Misses 64 47 -17 ☔ View full report in Codecov by Sentry. |
alhayward
requested review from
ericbuckley and
cbrinson-rise8
as code owners
November 19, 2024 23:35
ericbuckley
reviewed
Nov 20, 2024
ericbuckley
reviewed
Nov 20, 2024
Co-authored-by: cbrinson-rise8 <[email protected]>
cbrinson-rise8
approved these changes
Nov 27, 2024
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename feature matching and evaluation functions for clarity
Feature Matching
feature_match_any
->compare_match_any
feature_match_exact
->compare_match_all
feature_match_fuzzy_string
->compare_fuzzy_match
feature_match_log_odds_fuzzy_compare
->compare_probabilistic_fuzzy_match
Evaluation
eval_perfect_match
->rule_match
eval_log_odds_cutoff
->rule_probabilistic_match
Related Issues
closes #109
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: