Skip to content

fix: backend url variable name made consistent #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TomJohnZ
Copy link

Fixed simple typo for backend ccsync url variable name

Description

Changes ManageTaskChampionCreds url setter (championApiUrl) to match CredentialsStorage url getter (ccsyncBackendUrl)

Fixes #(455)

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

---
Fixed simple typo for backend ccsync url variable name
@SGI-CAPP-AT2
Copy link
Collaborator

@TomJohnZ , This issue is already fixed by #457

@SGI-CAPP-AT2 SGI-CAPP-AT2 added the duplicate This issue or pull request already exists label Jun 20, 2025
@TomJohnZ
Copy link
Author

@SGI-CAPP-AT2 Thanks for the quick response!

However, I believe #457 fixed a related, but different, issue. I am currently trying to setup ccsync and taskwarrior-flutter to work with taskchampion-sync-server; even after building and installing an APK from 7a8379f (#457), I was still encountering the issues described in #455. However, after adding the fix in this PR, the app is successfully able to sync with csync.

It is my understanding that #457 fixes a name mismatch for setting/reading the "Taskchampion sync" setting toggle.

However, this PR is fixing a name mismatch for setting/handling the "CCSync Backend URL" textbox under "Configure TaskChampion".

It seems that the PR which introduced the URL input (#429) originally used the name championApiUrl everywhere for the variable holding the backend URL. However, is appears that a reviewer requested that the variable be renamed to ccsyncBackendUrl. This was correctly changed for the getter:

static const String _apiUrlKey = 'ccsyncBackendUrl';

However, it was not updated in the setter:
await prefs.setString('championApiUrl', _ccsyncBackendUrlController.text);

Therefore, this mismatch means that a "CCSync Backend URL" will not actually be saved anywhere, causing sync attempts to fail.

@SGI-CAPP-AT2 SGI-CAPP-AT2 reopened this Jun 22, 2025
@SGI-CAPP-AT2
Copy link
Collaborator

Yeah @TomJohnZ ,
Sorry for reviewing very quick earlier.

I'll test the PR and will merge soon.

Thank you for explaining.

@SGI-CAPP-AT2 SGI-CAPP-AT2 removed the duplicate This issue or pull request already exists label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants