Add return type hints to chunkedgraph
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollman
approved these changes
Jan 17, 2024
fcollman
reviewed
Jan 17, 2024
| @@ -529,7 +528,7 @@ def execute_split( | |||
| root_id, | |||
| source_supervoxels=None, | |||
| sink_supervoxels=None, | |||
| ): | |||
| ) -> tuple[int, list]: | |||
There was a problem hiding this comment.
this seems to be improper syntax in our testing environment
There was a problem hiding this comment.
@fcollman what python versions are supposed to be supported? I can't actually find that information anywhere
I think this must be a python version thing; this works for me on 3.11. i have a vague memory of Tuple changing to tuple or something like that
There was a problem hiding this comment.
Recommend merging the above first and rerunning tests for this one on all versions, but I think this should be fixed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.