Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some missing comments #96

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

nimrof
Copy link
Collaborator

@nimrof nimrof commented Mar 29, 2024

Only 493 missing comments left :)

a few places i have change function from public -> private

@nimrof nimrof added the documentation Improvements or additions to documentation label Mar 29, 2024
@nimrof nimrof self-assigned this Mar 29, 2024
@nimrof nimrof marked this pull request as ready for review March 29, 2024 20:47
@trojanobelix
Copy link
Collaborator

Looks good. Merge!

@nimrof nimrof merged commit 0c3f6ae into CANopenNode:main Mar 30, 2024
1 check passed
@nimrof nimrof deleted the xml-comments branch March 30, 2024 06:06
@CANopenNode
Copy link
Owner

Only 493 missing comments left :)

One more reason, why to remove obsolete large files like CanOpenXDD.cs, CanOpenXML.cs, Bridge.cs

@trojanobelix, what do you think about it? (see #77 (comment))

@trojanobelix
Copy link
Collaborator

Agree for Bridge and CanOpenXML, not sure about CanOpenXDD. But we will see which stuff is needed.

@CANopenNode
Copy link
Owner

Agree for Bridge and CanOpenXML, not sure about CanOpenXDD. But we will see which stuff is needed.

There if CanOpenXDD_1_1, which is fully operational.
CanOpenXDD is older implementation of an older version of the same standard and is not working well.

@trojanobelix
Copy link
Collaborator

trojanobelix commented Apr 4, 2024 via email

@nimrof
Copy link
Collaborator Author

nimrof commented Apr 4, 2024

I do not have a need to remove support a format if it still in use, especially if it is in use by someone that is a active contributor to the project.

@CANopenNode
Copy link
Owner

I know, but unfortunately some test programmes only support the old version.

I didn't know for that. Than it should stay, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants