Skip to content

Conversation

nimrof
Copy link
Collaborator

@nimrof nimrof commented Mar 28, 2024

Hi all,
This finally adds compilation and support for building for .net 6 in addition to .net 4.8.1
It still needs msbuild to build the gui application, but the rest should be able to compile and run on pure multiplattform dotnet

On github it will do a matrix build to and test combination of release/debug & .net4.8.1/6.

@nimrof nimrof added the enhancement New feature or request label Mar 28, 2024
@nimrof nimrof self-assigned this Mar 28, 2024
@nimrof nimrof mentioned this pull request Mar 28, 2024
@trojanobelix
Copy link
Collaborator

Hi @nimrof, I'm a bit unsure about the status of this PR. Do I need to do anything? The conflicts in the project files are obviously and easy to resolve.

@nimrof
Copy link
Collaborator Author

nimrof commented Apr 3, 2024

Hi @nimrof, I'm a bit unsure about the status of this PR. Do I need to do anything? The conflicts in the project files are obviously and easy to resolve.

Hi @trojanobelix ,
I should have announced it much better,
but i wanted someone to check & approve it. it is a "big" change

It should not affect the 4.8.1 version in any way and we can mark the .net 6 as beta so i do not see it as a problem, but sometimes i mess up and its nice to have someone else to check my work.

Will try to merge it when i get off work later today, then i will also close #77

edit: thanks for the check btw 👍

@nimrof nimrof requested a review from trojanobelix April 3, 2024 19:47
@nimrof nimrof merged commit fd5c2a5 into CANopenNode:main Apr 3, 2024
@nimrof nimrof deleted the dotnet6-support branch April 3, 2024 20:07
@trojanobelix
Copy link
Collaborator

For me, it makes the most sense to use this version in my daily work. Certainly not 100% coverage, but if there are
major bugs we can always go back.

With the new release system, we can also get experience from others more quickly. I would welcome a 6.0 beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants