removed canopennode xml support #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrof
commented
Apr 2, 2024
|
|
||
| eds.Loadfile(path); | ||
| Bridge bridge = new Bridge(); //tell me again why bridge is not static? | ||
| dev = bridge.convert(eds); | ||
|
|
||
| DeviceView device = new DeviceView(eds, network); |
There was a problem hiding this comment.
No idea why bridge is used here 🤔
nimrof
commented
Apr 2, 2024
| @@ -69,10 +69,6 @@ Library | |||
| * Read EDS/DCF/XDC file and parse contents to approprate classes | |||
| * Dump EDS/DCF classes via ToString() | |||
| * Save EDS/DCF classes back to EDS file | |||
| * Read CanOpenNode xml project file | |||
| * Write CanOpenNode xmlproject file | |||
| * Switch formats between EDS/DCF and CanOpenNode XML (note to EDS will result in | |||
There was a problem hiding this comment.
Should this line be rewritten or is it okay to remove it?
There was a problem hiding this comment.
It is okay, if it is removed. README.md will need some refreshment too.
CANopenNode
approved these changes
Apr 2, 2024
trojanobelix
approved these changes
Apr 3, 2024
|
Thanks for the checks. |
|
@CANopenNode @nimrof: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think i got it all, but please test it out
Closes #103