Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LM Toolkit Refactor #381

Open
wants to merge 1 commit into
base: BANFF_lm
Choose a base branch
from
Open

LM Toolkit Refactor #381

wants to merge 1 commit into from

Conversation

dcgaines
Copy link
Collaborator

@dcgaines dcgaines commented Mar 7, 2025

Merging toolkit refactor into Banff LM branch for sim testing.

Overview

Replaced all custom models in the language module with language model adapters. Adapters rely on aactextpredict, our new LM toolkit, for the heavy lifting and only need to handle BciPy-specific things like special space and backspace characters and response type properties.

Ticket

Link a pivotal ticket here

Contributions

  • Deprecated LanguageModel classes in favor of LanguageModelAdapter classes.
  • Consolidated predict methods into the super class, only override when needed (Oracle).
  • Renamed KenLM model to NGram to match the aactextpredict package.
  • Updated all references to KenLM and LanguageModel classes to match new names/classes

Test

  • Ran all pytest cases

Documentation

  • Language module README updated. Added links to textpredict repo and AAC adapting arXiv paper.

Changelog

  • Is the CHANGELOG.md updated with your detailed changes?
  • Not yet.

Merging unigram removal into toolkit refactor
@dcgaines dcgaines requested review from lawhead and tab-cmd March 7, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant