Skip to content

Conversation

@dingxiangfei2009
Copy link

@dingxiangfei2009 dingxiangfei2009 commented Oct 30, 2025

cc @davidben

I inspected the these test vector files and I suppose that it is preferable to have tests with similar procedures in their own files.

Fix #191

It is preferable to have tests with similar procedures in their own
files.

Signed-off-by: Xiangfei Ding <[email protected]>
@sgmenda
Copy link

sgmenda commented Nov 24, 2025

@cpu can we merge this? as @davidben noted in #191 (comment) it would simplify parsing and be in-line with the ML-DSA vectors. also I don't see any objections in #191.

@cpu
Copy link
Member

cpu commented Nov 25, 2025

Sorry for letting this one sit.

I talked to Filippo recently and he convinced me that we should go ahead and do the split, but also mentioned that this PR's filenames don't seem right and that we should do a pass to make sure notes & other fields are only present in the files that use them. I think we should address those points before merging.

Separately CI should also enforce the unique type per-test file property & we should describe that in the contrib docs, but neither need to be a blocker here.

@cpu
Copy link
Member

cpu commented Dec 1, 2025

I think we should address those points before merging.

I went ahead and recreated this PR here: #199 I'm going to close this iteration out since mine also has the contribution docs update + linting.

Thanks for getting this started dingxiangfei2009!

@cpu cpu closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ML-KEM tests have multiple test types in one file

3 participants