Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for assumed role credentials in the s3 backend #219

Merged
merged 3 commits into from
Jan 15, 2025
Merged

add support for assumed role credentials in the s3 backend #219

merged 3 commits into from
Jan 15, 2025

Conversation

grant-higgins-0
Copy link
Contributor

@grant-higgins-0 grant-higgins-0 commented Dec 23, 2024 •
edited
Loading

Add support for role based authentication in s3 backend.

@c2fo-cibot c2fo-cibot bot added the size/S Denotes a PR that changes 10-29 lines label Dec 23, 2024
funkyshu
funkyshu requested changes Dec 26, 2024
View reviewed changes
Copy link
Member

@funkyshu funkyshu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but can you be sure to update the docs? and update the CHANGELOG.md

@c2fo-cibot c2fo-cibot bot added size/M Denotes a PR that changes 30-99 lines and removed size/S Denotes a PR that changes 10-29 lines labels Dec 26, 2024
funkyshu
funkyshu requested changes Dec 27, 2024
View reviewed changes
@grant-higgins-0 grant-higgins-0 marked this pull request as ready for review January 14, 2025 16:00
@grant-higgins-0 grant-higgins-0 merged commit ecb70b8 into main Jan 15, 2025
8 checks passed
@grant-higgins-0 grant-higgins-0 deleted the assume-role-support branch January 15, 2025 15:44
@NathanBaulch NathanBaulch mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funkyshu funkyshu funkyshu approved these changes

@dustin-schnee dustin-schnee dustin-schnee approved these changes

@katiehrenchir katiehrenchir Awaiting requested review from katiehrenchir

@dhondgepooja dhondgepooja Awaiting requested review from dhondgepooja

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grant-higgins-0 @funkyshu @dustin-schnee