Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sftp backend to to fix issue where some servers return a gene… #159

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

funkyshu
Copy link
Member

@funkyshu funkyshu commented Feb 2, 2024

…ric error message when a file is opened for RW on Read(). Fixes #158.

…ric error message when a file is opened for RW on Read(). Fixes #158.
@c2fo-cibot c2fo-cibot bot added the size/L Denotes a PR that changes 100-499 lines label Feb 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (d995180) 71.66% compared to head (452a908) 71.51%.

Files Patch % Lines
backend/sftp/file.go 56.52% 15 Missing and 5 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   71.66%   71.51%   -0.16%     
==========================================
  Files          40       40              
  Lines        4638     4672      +34     
==========================================
+ Hits         3324     3341      +17     
- Misses       1043     1056      +13     
- Partials      271      275       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@funkyshu funkyshu merged commit 02139cf into master Feb 2, 2024
8 checks passed
@funkyshu funkyshu deleted the open_rw_on_read_bug_158 branch February 2, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening RW on read causes issues with some SFTP servers.
3 participants