Show deleted bytes in the deletion status line - #405
Merged
Merged
Conversation
<!-- agent --> Report deletion progress as the cumulative number and size of removed entries. Remaining bytes are already visible in the marked pane and total disk usage. Reuse the removed-byte counter for the status message, remove the unused remaining-byte counter, and update delete/trash wording in all five languages. Extend the existing deletion journey to check the initial zero, a successful removal, and a zero-byte removal while preserving failed marks. Assisted-by: GPT 6.0 Co-authored-by: GPT 6.0 <codex@openai.com>
Byron
force-pushed
the
del-remaining
branch
from
September 25, 2026 02:43
3089040 to
9a3bfa1
Compare
Byron
marked this pull request as ready for review
September 25, 2026 02:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Created by Codex on behalf of Byron. Byron will review before this is ready to merge.
Summary
Show cumulative deleted bytes alongside the deleted item count in the bottom status line, for example
Deleted 42 items (123 MB).... Apply the same change to trash operations and all five supported languages.Context
Remaining sizes are already visible in the marked pane and total disk usage. The status message now uses the existing removed-byte counter, and the redundant remaining-byte field and updates are removed.
Validation
cargo test --locked --offline --bin dua deletion— 17 passed. The updated journey test checks progress starts at zero, counts removed bytes, and preserves the byte total when removing a zero-byte entry.cargo fmt --all -- --check— passed.git diff --check— passed.User Prompts