Intersection of Two Arrays step1-3 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoshi2025s
reviewed
Jan 11, 2025
Comment on lines
+21
to
+22
| - 空間計算量 0(n+m) | ||
| - 最大の大きさn,mのsetを作るから |
There was a problem hiding this comment.
set(nums1)の空間計算量としては、len(nums1)というより、nums1の文字の種類数によって決まると思いました。
仮に文字種をアルファベットに限定すると定数になるので、結果として空間計算量はO(1)になるのでは？と考えています。
colorbox/leetcode#29 (comment)
There was a problem hiding this comment.
すみません、別の問題と間違えていました！空間計算量はO(n+m)であってると思います
oda
reviewed
Jan 11, 2025
| ```python | ||
| class Solution(): | ||
| def intersection(self, nums1: List[int], nums2: List[int]) -> List[int]: | ||
| if len(nums1) > len(nums2): |
There was a problem hiding this comment.
これ、どっちがいいんですかね。
大きい方を set で変換して、小さい方を iter で舐めるというコードですが、舐める方が簡単で速そうな気がするのでそっちのほうが大きいほうがよいのではないでしょうか。
Python で速度の話は、(そもそもインタープリターのオーバーヘッドが大きいので)結構不毛なことになる気はしています。
There was a problem hiding this comment.
なるほど。
計算量のことを考えてみてというコメントをいただいてから速度について考えるようになったのですが、このレベルの細かい話をしたいならC++とかjavaで書いた方がいいんですかね？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題：
https://leetcode.com/problems/intersection-of-two-arrays/description/