Skip to content

testing/update osm.json5 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

testing/update osm.json5 #66

wants to merge 1 commit into from

Conversation

sys0pt
Copy link

@sys0pt sys0pt commented Aug 21, 2024

Minecolony townhall testing

Minecolony townhall testing
@SmylerMC
Copy link
Collaborator

Hi @sys0pt , is this a mistake ?

@sys0pt
Copy link
Author

sys0pt commented Aug 21, 2024

no, just want to test some world gen stuff with new (custom) structures and buildungs.

@SmylerMC
Copy link
Collaborator

You just requested to merge your one commit to osm.json5 into the main branch of the mod 😅 , which would break it. May I suggest working locally or with your own repository for testing? If you only want to make changes to osm.json5, you in fact don't even need to work with the sources, you can install a custom osm.json5 in the terraplusplus subdirectory in your .minecraft and it should pick it up.

As for what I think you are trying to do, Terraplusplus does not support generating structures with osm.json5. If you really want to do that, you will need to implement your own DrawFunction in Java for it to work. There were plans to rework the generation config and I wanted to add support for structure on that occasion (see #43 ), but it looks like neither @DaMatrix nor I have time to work on this anymore so it won't happen any time soon.

@sys0pt
Copy link
Author

sys0pt commented Aug 21, 2024

My bad for being a noob. I'd love to join forces and help you out. Got a lot of time and want to make a custom fork-osm.json5, for custom nbt schematic structures. If i can help you in any way, let me know :)
sry for accidentally merging to main

@SmylerMC
Copy link
Collaborator

SmylerMC commented Aug 21, 2024

No worries, we have all been there! For next time, if you want to open a pull request for something which is a work in progress, you can open it as a draft, that way project maintainers know it's not supposed to be ready.

@sys0pt
Copy link
Author

sys0pt commented Aug 21, 2024

My goal is:
-generating more osm-geo tags
-making it compatible with other mods, that generate structures
-finishing the Point
-improving osm capabilities as in (#43) "Internal support to generate small structures at the location of Points"

=> osm tags genertating nbt schematics on point, instead of building outline (for large scale population simulation modpack stuff)

@sys0pt
Copy link
Author

sys0pt commented Aug 23, 2024

@SmylerMC Not sure why but my repo wont load as active mod with the new draw function. surely im missing out on some details, but idk what exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants