Add Feature/swipe component #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the lint-staged warning
src/components/Swipe.vue
Outdated
| }); | ||
| </script> | ||
|
|
||
| <style lang='scss'> |
Contributor
There was a problem hiding this comment.
Move all the design part into the src/assets/scss/base/main.scss
Member
Author
There was a problem hiding this comment.
So we only use a one scss file?
src/components/Swipe.vue
Outdated
| border-radius: 3rem; | ||
| color: $textColor; | ||
| padding: 2rem; | ||
| width:300px; |
Contributor
There was a problem hiding this comment.
Please change to rem (1rem = 10px). Here it would be width: 30rem
* fix: Fixed styling for Input, Radio, Checkbox, Texarea. Added Global Styling into vue.config.js + inputs.scss * fix: scss setup correction * style: remove shared styles from components * style: reformat code * style: px to rem * refactor: rem instead of px, font-size fixed * refactor: Refactored design and made it BEM-coding-styled. * refactor: Refactored design and made shortened BEM via SCSS. Co-authored-by: Robin Kemna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16